/[blink]
Chromium logo

Revision 157259


Jump to revision: Previous Next
Author: haraken@chromium.org
Date: Thu Sep 5 02:06:57 2013 UTC (9 years, 8 months ago)
Changed paths: 1
Log Message:
Fix threading races on WebAudioSourceProviderImpl::provideInput

Fix threading races on WebAudioSourceProviderImpl::provideInput 

According to the crash report (https://cluster-fuzz.appspot.com/testcase?key=4697390229487616), 
there is a threading race. Specifically, WebAudioSourceProviderImpl can be destructed by the main thread while WebAudioSourceProviderImpl::Stop() is being called by the audio thread. 

The core problem is that we're not calling WebAudioSourceProviderImpl::setClient(NULL) when HTMLMediaElement clears the audio source provider. 

BUG=284786
No tests because the crash depends on threading races and thus not reproducible.

Review URL: https://chromiumcodereview.appspot.com/23969007

Changed paths

Path Details
Directorytrunk/Source/core/html/HTMLMediaElement.cpp modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help