/[blink]
Chromium logo

Revision 157392


Jump to revision: Previous Next
Author: leviw@chromium.org
Date: Fri Sep 6 23:40:42 2013 UTC (9 years, 8 months ago)
Changed paths: 4
Log Message:
Avoid collapsing anonymous block children already being destroyed

When normalizing a block with anonymous blocks for first-letter,
before content, and contained text, a collapsing anonymous block
cascade is triggered that attempts to collapse the contained
text's anonymous block within its destruction method. To avoid
this, adding logic to bail early if we're already destroying
the child anonymous block we're trying to collapse.

While in the function, doing a little cleanup to make it more
obvious that it only operates on RenderBlocks, not RenderBoxes,
and updating some of the comments to hopefully be more useful.

BUG=282088

Review URL: https://chromiumcodereview.appspot.com/23463021

Changed paths

Path Details
Directorytrunk/LayoutTests/fast/css-generated-content/normalize-with-first-letter-and-before-content-crash-expected.txt
(Copied from trunk/LayoutTests/editing/execCommand/format-block-removes-destination-crash-expected.txt, r157391)
added
Directorytrunk/LayoutTests/fast/css-generated-content/normalize-with-first-letter-and-before-content-crash.html
(Copied from trunk/LayoutTests/fast/css-generated-content/first-letter-next-sibling-crash.html, r157391)
added , text changed , props changed
Directorytrunk/Source/core/rendering/RenderBlock.cpp modified , text changed
Directorytrunk/Source/core/rendering/RenderBlock.h modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help