/[blink]
Chromium logo

Revision 158146


Jump to revision: Previous Next
Author: tyoshino@chromium.org
Date: Sat Sep 21 01:35:32 2013 UTC (9 years, 8 months ago)
Changed paths: 3
Log Message:
[XHR] Abort method execution when m_loader->cancel() in internalAbort() caused reentry

Calling cancel() on DocumentThreadableLoader may results in calling
window.onload synchronously. If open(), send(), etc. are called on the same
XMLHttpRequest object, it'll be hard to resolve conflict of states without
losing spec conformance. This CL avoids that by just aborting execution of
code for the outer method that calls internalAbort() if it returns false.

BUG=292422

Review URL: https://chromiumcodereview.appspot.com/24304004

Changed paths

Path Details
Directorytrunk/LayoutTests/http/tests/xmlhttprequest/reentrant-cancel-expected.txt modified , text changed
Directorytrunk/Source/core/xml/XMLHttpRequest.cpp modified , text changed
Directorytrunk/Source/core/xml/XMLHttpRequest.h modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help