/[blink]
Chromium logo

Revision 162655


Jump to revision: Previous Next
Author: esprehn@chromium.org
Date: Tue Nov 26 02:05:57 2013 UTC (9 years, 5 months ago)
Changed paths: 15
Log Message:
Fire overflowchanged events at raf timing

Running script inside layout leads to nasty security bugs and crashes,
instead we should defer overflowchanged events until raf time. This still
lets the author take an action before the paint preventing blinking and
jumpiness which was the reason we ran it inside layout, while avoiding the
pitfalls of synchronous script.

Unfortunately this patch makes us start firing overflowchanged even when a
node has been removed from the tree, but the old protection against it was
bad since it only checked inDocument() so removing a node and putting it in
another document would still let the event fire. Instead I plan to fix the
detach problem in a future patch since scroll events shouldn't fire for
detached nodes either.

This patch also lets us remove the paused-event-dispatch.html test which
was testing the suspend/resume logic I removed and for crashes that happen
with synchronous script inside layout which doesn't apply after this patch.

BUG=293534,323283
TEST=fast/events/overflowchanged-event-raf-timing.html

Review URL: https://codereview.chromium.org/82843003

Changed paths

Path Details
Directorytrunk/LayoutTests/fast/dynamic/paused-event-dispatch-expected.txt deleted
Directorytrunk/LayoutTests/fast/dynamic/paused-event-dispatch.html deleted
Directorytrunk/LayoutTests/fast/dynamic/resources/paused-event-dispatch-iframe.html deleted
Directorytrunk/LayoutTests/fast/events/overflowchanged-event-raf-timing-expected.txt added
Directorytrunk/LayoutTests/fast/events/overflowchanged-event-raf-timing.html added
Directorytrunk/Source/core/dom/Document.cpp modified , text changed
Directorytrunk/Source/core/dom/Document.h modified , text changed
Directorytrunk/Source/core/dom/ScriptedAnimationController.cpp modified , text changed
Directorytrunk/Source/core/dom/ScriptedAnimationController.h modified , text changed
Directorytrunk/Source/core/frame/FrameView.cpp modified , text changed
Directorytrunk/Source/core/frame/FrameView.h modified , text changed
Directorytrunk/Source/core/page/EventHandler.cpp modified , text changed
Directorytrunk/Source/core/page/EventHandler.h modified , text changed
Directorytrunk/Source/core/rendering/RenderBlock.cpp modified , text changed
Directorytrunk/Source/web/WebViewImpl.cpp modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help