/[blink]
Chromium logo

Revision 165009


Jump to revision: Previous Next
Author: fmalita@chromium.org
Date: Mon Jan 13 22:24:05 2014 UTC (9 years, 4 months ago)
Changed paths: 4
Log Message:
[SVG] Handle non-SVGAnimateElement results in calculateAnimatedValue()

Currently, SVGAnimateElement::calculateAnimatedValue() assumes that the
result element is a subtype of SVGAnimateElement, but that is not always
the case: SMILTimeContainer::updateAnimations() may pick an
SVGAnimateMotionElement for the result.

This CL is a workaround - we should take a good look at the SVG
animation type hierarchy and figure out why this is needed.

BUG=333176
R=pdr@chromium.org

Review URL: https://codereview.chromium.org/133893005

Changed paths

Path Details
Directorytrunk/LayoutTests/svg/custom/animate-motion-crash-expected.txt
(Copied from trunk/LayoutTests/svg/css/color-profile-crash-expected.txt, r165008)
added , props changed
Directorytrunk/LayoutTests/svg/custom/animate-motion-crash.svg added
Directorytrunk/Source/core/svg/SVGAnimateElement.cpp modified , text changed
Directorytrunk/Source/core/svg/animation/SMILTimeContainer.cpp modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help