/[blink]
Chromium logo

Revision 167993


Jump to revision: Previous Next
Author: tasak@google.com
Date: Thu Feb 27 08:37:53 2014 UTC (9 years, 2 months ago)
Changed paths: 6
Log Message:
Fix crash in SVGFontFaceElement::associatedFontElement crash when removing SVGFontFaceElement.

(1) We need to remove its font-face rule from FontCache when removing SVGFontFaceElement,

(2) We should not use old styles in RenderSVGInlineText::styleDidChange.
Since styleRecalc is done in document-order, we cannot see any styles of next renderer
(obtained by nextInPreOrder).
The old styles might have old fonts which are created by SVGFontFaceElement.

BUG=346192
TEST=fast/dom/discard-svg-font-face-crash.svg

Review URL: https://codereview.chromium.org/176853009

Changed paths

Path Details
Directorytrunk/LayoutTests/fast/dom/discard-svg-font-face-crash-expected.svg added
Directorytrunk/LayoutTests/fast/dom/discard-svg-font-face-crash.svg added
Directorytrunk/Source/core/rendering/svg/RenderSVGInlineText.cpp modified , text changed
Directorytrunk/Source/core/rendering/svg/RenderSVGText.cpp modified , text changed
Directorytrunk/Source/core/rendering/svg/RenderSVGText.h modified , text changed
Directorytrunk/Source/core/svg/SVGFontFaceElement.cpp modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help