/[blink]
Chromium logo

Revision 171216


Jump to revision: Previous Next
Author: tkent@chromium.org
Date: Thu Apr 10 01:45:36 2014 UTC (9 years, 1 month ago)
Changed paths: 5
Log Message:
Add renderer type checks to HTMLSelectElement event handlers.

focus() can change the renderer type.


This CL is based on a patch by jbutler@chromium.org. This CL fixed one bug in
the original CL, and added a test.
The test is only for OSX because other platforms don't use
HTMLSelectElement::platformHandleKeydownEvent.

BUG=349903
TEST=automated

Review URL: https://codereview.chromium.org/230143004

Changed paths

Path Details
Directorytrunk/LayoutTests/fast/forms/select/select-change-type-on-mousedown-focus-expected.txt
(Copied from trunk/LayoutTests/fast/dom/css-inline-style-declaration-crash-expected.txt, r171215)
added , text changed , props changed
Directorytrunk/LayoutTests/fast/forms/select/select-change-type-on-mousedown-focus.html added
Directorytrunk/LayoutTests/platform/mac/fast/forms/select/select-change-type-on-keydown-focus-expected.txt
(Copied from trunk/LayoutTests/fast/dom/css-inline-style-declaration-crash-expected.txt, r171215)
added , text changed , props changed
Directorytrunk/LayoutTests/platform/mac/fast/forms/select/select-change-type-on-keydown-focus.html added
Directorytrunk/Source/core/html/HTMLSelectElement.cpp modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help