/[blink]
Chromium logo

Revision 174923


Jump to revision: Previous Next
Author: kouhei@chromium.org
Date: Wed May 28 02:40:15 2014 UTC (8 years, 11 months ago)
Changed paths: 13
Log Message:
SVG: SVGAnimateElement should not cache |m_animatedElements|

Before this change, SVGAnimateElement cached resolved element instances in 
|m_animatedElements|. However, this is not updated synchronously when <use> 
shadow dom/instance tree is torn down or new instances are added.

The patch changes SVGAnimateElement to resolve its target instances on the fly 
when needed.

As |m_animatedElements| are no longer kept, we do not guarantee that 
animationStarted hook is called before each animation. animationEnded
hook is guaranteed to be called for elements stayed in the tree 
when the animation ended, but it may not be called for the animated element 
|removedFrom| the document tree while animation.

BUG=369860

Review URL: https://codereview.chromium.org/298873003

Changed paths

Path Details
Directorytrunk/LayoutTests/svg/dom/remove-use-target-element-indirectly-expected.txt
(Copied from trunk/LayoutTests/svg/dom/move-animating-svg-to-other-frame-expected.txt, r174922)
added , text changed
Directorytrunk/LayoutTests/svg/dom/remove-use-target-element-indirectly.html added
Directorytrunk/LayoutTests/svg/dom/resources/svg-with-animate-use.svg added
Directorytrunk/Source/core/svg/SVGAnimateElement.cpp modified , text changed
Directorytrunk/Source/core/svg/SVGAnimateElement.h modified , text changed
Directorytrunk/Source/core/svg/SVGAnimatedAngle.cpp modified , text changed
Directorytrunk/Source/core/svg/SVGAnimatedInteger.cpp modified , text changed
Directorytrunk/Source/core/svg/SVGAnimatedNumber.cpp modified , text changed
Directorytrunk/Source/core/svg/SVGAnimatedTypeAnimator.h modified , text changed
Directorytrunk/Source/core/svg/SVGStaticStringList.cpp modified , text changed
Directorytrunk/Source/core/svg/SVGStaticStringList.h modified , text changed
Directorytrunk/Source/core/svg/properties/SVGAnimatedProperty.cpp modified , text changed
Directorytrunk/Source/core/svg/properties/SVGAnimatedProperty.h modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help