/[blink]
Chromium logo

Revision 177250


Jump to revision: Previous Next
Author: rtoy@chromium.org
Date: Mon Jun 30 23:29:01 2014 UTC (8 years, 10 months ago)
Changed paths: 3
Log Message:
Initialize value since calculateFinalValues may fail to do so.

Fix threading issue where updateCoefficientsIfNecessary was not always
called from the audio thread. This causes the value not to be
initialized.

Thus,

o Initialize the variable to some value, just in case.
o Split updateCoefficientsIfNecessary into two functions with the code
  that sets the coefficients pulled out in to the new function
  updateCoefficients.
o Simplify updateCoefficientsIfNecessary since useSmoothing was always
  true, and forceUpdate is not longer needed.
o Add process lock to prevent the audio thread from updating the
  coefficients while they are being read in the main thread. The audio
  thread will update them the next time around.
o Make getFrequencyResponse set the lock while reading the
  coefficients of the biquad in preparation for computing the
  frequency response.

BUG=389219

Review URL: https://codereview.chromium.org/354213002

Changed paths

Path Details
Directorytrunk/Source/modules/webaudio/AudioParam.cpp modified , text changed
Directorytrunk/Source/modules/webaudio/BiquadDSPKernel.cpp modified , text changed
Directorytrunk/Source/modules/webaudio/BiquadDSPKernel.h modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help