/[blink]
Chromium logo

Revision 179340


Jump to revision: Previous Next
Author: jsbell@chromium.org
Date: Thu Jul 31 19:31:23 2014 UTC (8 years, 9 months ago)
Changed paths: 2
Log Message:
Simply V8 wrapper generation for Event objects

When trying to determine what kind of wrapper to produce, we'd iterate
over core event types (exiting early) then try iterating over module
event types. If the latter yielded an empty handle we'd wrap the
object as just a V8Event, which is bogus. This could happen in a
worker if the object was indeed a module event type, but the worker
had been asynchronously stopped and v8 was politely failing to produce
a wrapper.

Remove the fallback case, and instead assert if we make it as far as
module event type iteration and no match is found.

BUG=395411
R=abarth,tasak

Review URL: https://codereview.chromium.org/424813007

Changed paths

Path Details
Directorytrunk/Source/bindings/core/v8/custom/V8EventCustom.cpp modified , text changed
Directorytrunk/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help