/[blink]
Chromium logo

Revision 186914


Jump to revision: Previous Next
Author: tkent@chromium.org
Date: Thu Dec 11 05:10:50 2014 UTC (8 years, 5 months ago)
Changed paths: 1
Log Message:
Web Audio: Oilpan: Trace AudioSummingJunction::m_renderingOutputs

m_renderingOutpus is a vector of AudioNodeOutput raw pointers.  They are raw
pointers because the vector is allocated in the audio rendering thread, which
has no Oilpan support.  However, They can be last references to the AudioNodeOutput
objects, and Oilpan GC during audio rendering could collect the objects.  We
need to trace the contents of m_renderingOutputs.

This CL fixes crashes.  But unused AudioNodes in the graph are not
destructed automatically unless JavaScript code explicitly disconnect
them from the graph.

BUG=434136

Review URL: https://codereview.chromium.org/782603004

Changed paths

Path Details
Directorytrunk/Source/modules/webaudio/AudioSummingJunction.cpp modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help