/[blink]
Chromium logo

Revision 189886


Jump to revision: Previous Next
Author: marja@chromium.org
Date: Tue Feb 10 11:36:10 2015 UTC (8 years, 3 months ago)
Changed paths: 9
Log Message:
Script moving fixes related to context documents.

There were 2 bugs:

1) Moving script element to a new document whose context document is the same as
the current document: we ended up doing ScriptRunner::movePendingAsyncScript to
itself and that does the wrong thing (just removes the script).

2) Moving script element to a new document which is not its own context
document, and then moving it somewhere else. The script was not where we
expected it to be (it was in the context document, we expected it to be in the
non-context document).

BUG=456059

Review URL: https://codereview.chromium.org/913473002

Changed paths

Path Details
Directorytrunk/LayoutTests/fast/dom/HTMLScriptElement/resources/move-back-from-non-contextdoc.html
(Copied from trunk/LayoutTests/fast/dom/HTMLScriptElement/resources/append-child-adopt-node-error-frame.html, r189885)
added , text changed
Directorytrunk/LayoutTests/fast/dom/HTMLScriptElement/resources/move-back-from-non-contextdoc.svg
(Copied from trunk/LayoutTests/fast/dom/HTMLScriptElement/resources/append-child-adopt-node-error-frame.svg, r189885)
added , text changed
Directorytrunk/LayoutTests/fast/dom/HTMLScriptElement/resources/move-from-non-contextdoc-to-iframe.html added
Directorytrunk/LayoutTests/fast/dom/HTMLScriptElement/script-moving-from-non-contextdoc-expected.txt
(Copied from trunk/LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-error-crash-expected.txt, r189885)
added , text changed
Directorytrunk/LayoutTests/fast/dom/HTMLScriptElement/script-moving-from-non-contextdoc.html
(Copied from trunk/LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-crash.html, r189885)
added , text changed
Directorytrunk/Source/core/dom/ScriptRunner.cpp modified , text changed
Directorytrunk/Source/core/dom/ScriptRunner.h modified , text changed
Directorytrunk/Source/core/html/HTMLScriptElement.cpp modified , text changed
Directorytrunk/Source/core/svg/SVGScriptElement.cpp modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help