/[blink]
Chromium logo

Revision 190980


Jump to revision: Previous Next
Author: kouhei@chromium.org
Date: Fri Feb 27 07:11:07 2015 UTC (8 years, 2 months ago)
Changed paths: 8
Log Message:
Fix inconsistent frame detach behavior of ContainerNode::parserRemoveChild.

Before this CL, ContainerNode::parserRemoveChild didn't detach descendent
<frame>s like ContainerNode::removeChild did.
ContainerNode::parserRemoveChild is called from document parsers for reparenting,
and this may leave the <frame>s in broken state.

This CL fixes the issue by issuing ChildFrameDisconnector from parserRemoveChild.

Node::updateAncestorConnectedSubframeCountForRemoval is removed,
as the decrement is now issued from HTMLFrameOwnerElement::clearContentFrame
called from fromChildFrameDisconnector.

Rebaselined:
fast/parser/adoption-agency-crash-01.html
fast/parser/adoption-agency-crash-03.html
- The iframes parser removed shouldn't be invoked onload handler anyway.

BUG=456518

Review URL: https://codereview.chromium.org/948793003

Changed paths

Path Details
Directorytrunk/LayoutTests/fast/css/stylesheet-candidate-nodes-crash-expected.txt modified , text changed , props changed
Directorytrunk/LayoutTests/fast/frames/reparented-iframe-cleared-contentWindow-expected.txt
(Copied from trunk/LayoutTests/fast/images/webgl-teximage2d-expected.txt, r190979)
added , text changed
Directorytrunk/LayoutTests/fast/frames/reparented-iframe-cleared-contentWindow.html added
Directorytrunk/LayoutTests/fast/parser/adoption-agency-crash-01-expected.txt modified , text changed
Directorytrunk/LayoutTests/fast/parser/adoption-agency-crash-03-expected.txt modified , text changed
Directorytrunk/Source/core/dom/ContainerNode.cpp modified , text changed
Directorytrunk/Source/core/dom/Node.cpp modified , text changed
Directorytrunk/Source/core/dom/Node.h modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help