/[blink]
Chromium logo

Revision 193911


Jump to revision: Previous Next
Author: schenney@chromium.org
Date: Thu Apr 16 23:40:41 2015 UTC (8 years, 1 month ago)
Changed paths: 7
Log Message:
Rework the checks for too-few values in feColorMatrix filter.

Revert the prevous fix because it was flat-out wrong for some
filters. Here we add checks at all points the values are used,
because it is impossible to enforce an always-valid m_values vector
inside the FEColorMatrix object.

For example, we need to support any ordering of setAttribute('type', ...)
and setAttribute('values', ...), but the valid number of values depends
on the type. We couldn't set the type from "hueRotate" to "matrix", for
example, without first adding more values than are necessary for the
"hueRotate". That's a bad user experience.

R=fs@opera.com,ed@opera.com,pdr@chromium.org
BUG=468519

Review URL: https://codereview.chromium.org/1087283002

Changed paths

Path Details
Directorytrunk/LayoutTests/svg/filters/feColorMatrix-setAttribute-crash1-expected.txt
(Copied from trunk/LayoutTests/svg/animations/animateTransform-circular-linked-syncbases-expected.txt, r193910)
added
Directorytrunk/LayoutTests/svg/filters/feColorMatrix-setAttribute-crash1.html added
Directorytrunk/LayoutTests/svg/filters/feColorMatrix-setAttribute-crash2-expected.txt
(Copied from trunk/LayoutTests/svg/animations/animateTransform-circular-linked-syncbases-expected.txt, r193910)
added
Directorytrunk/LayoutTests/svg/filters/feColorMatrix-setAttribute-crash2.html added
Directorytrunk/Source/core/svg/SVGFEColorMatrixElement.cpp modified , text changed
Directorytrunk/Source/platform/graphics/filters/FEColorMatrix.cpp modified , text changed
Directorytrunk/Source/platform/graphics/filters/FEColorMatrix.h modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help