/[blink]
Chromium logo

Revision 194421


Jump to revision: Previous Next
Author: fs@opera.com
Date: Sat Apr 25 01:10:46 2015 UTC (8 years ago)
Changed paths: 3
Log Message:
Avoid transiently creating disallowed elements when building <use> trees

When building a shadow tree for a <use>, a direct reference to a
"disallowed" element would cause the element to first be inserted before
buildShadowTree() noticed it's disallowed and returns false, so it's
removed again.
This transient mutation could take place while computing an animation
update, if a CSS property was being animated and the layout tree/style
was dirty.
Avoid the insert-remove sequence by checking if the initial target is
disallowed up-front. This matches how it's done in the general subtree
building case inside buildShadowTree().

BUG=478549

Review URL: https://codereview.chromium.org/1105873002

Changed paths

Path Details
Directorytrunk/LayoutTests/svg/custom/use-referencing-animation-crash-expected.txt added
Directorytrunk/LayoutTests/svg/custom/use-referencing-animation-crash.html added
Directorytrunk/Source/core/svg/SVGUseElement.cpp modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help