/[blink]
Chromium logo

Revision 197139


Jump to revision: Previous Next
Author: japhet@chromium.org
Date: Mon Jun 15 21:26:44 2015 UTC (7 years, 11 months ago)
Changed paths: 6
Log Message:
Fix the logic that limits the number of frames in a page.

This check apparently doesn't run soon enough, and we can create more than the
intended limit of 1000 frames. Once we hit 1024,
NodeRareData::m_connecetedFrameCount can overflow and we no longer fully detach
Frames from their owners at teardown.

BUG=493243
TEST=WebFrameTest.MaxFramesDetach

Review URL: https://codereview.chromium.org/1180603002

Changed paths

Path Details
Directorytrunk/Source/core/dom/NodeRareData.cpp modified , text changed
Directorytrunk/Source/core/dom/NodeRareData.h modified , text changed
Directorytrunk/Source/core/frame/LocalFrame.cpp modified , text changed
Directorytrunk/Source/core/html/HTMLFrameOwnerElement.cpp modified , text changed
Directorytrunk/Source/web/tests/WebFrameTest.cpp modified , text changed
Directorytrunk/Source/web/tests/data/max-frames-detach.html added

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help