/[chrome]
Chromium logo

Revision 235302


Jump to revision: Previous Next
Author: jam@chromium.org
Date: Fri Nov 15 07:47:16 2013 UTC (9 years, 6 months ago)
Changed paths: 2
Log Message:
Fix crash in WebContentsViewAura::WindowObserver that happens when switching tabs. The exact repro steps were:

1) open an empty page
2) print preview
3) open a new tab
4) go back to original tab
5) close print preview
6) switch to the new tab

The crash happened at step 4 because the second tab got removed from the same root window as the print preview's observer. We weren't unobserving all the children of the root window at that point.

BUG=318791
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235267

Review URL: https://codereview.chromium.org/69813005

Changed paths

Path Details
Directorytrunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc modified , text changed
Directorytrunk/src/content/browser/web_contents/web_contents_view_aura.cc modified , text changed

Powered by ViewVC 1.1.26 ViewVC Help