/[chrome]
Chromium logo

Revision 256918


Jump to revision: Previous Next
Author: piman@chromium.org
Date: Thu Mar 13 20:35:22 2014 UTC (9 years, 2 months ago)
Changed paths: 4
Log Message:
Use CheckedNumerics in AsyncPixelTransfersCompletedQuery, add tests

This is a follow-up to https://codereview.chromium.org/198253002/
1- It converts the code to use CheckedNumerics
2- It adds unit tests:
  * converts existing tests to exercise all query types
  * adds an additional test to exercise overflow explicitly
3- Fixes a minor issue with GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM, where
out-of-bounds access would be silently failing instead of losing the context.

BUG=351852

Review URL: https://codereview.chromium.org/196633009

Changed paths

Path Details
Directorytrunk/src/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc modified , text changed
Directorytrunk/src/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc modified , text changed
Directorytrunk/src/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h modified , text changed
Directorytrunk/src/gpu/command_buffer/service/query_manager.cc modified , text changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help