/[chrome]
Chromium logo

Revision 261817


Jump to revision: Previous Next
Author: danakj@chromium.org
Date: Fri Apr 4 19:01:21 2014 UTC (9 years, 1 month ago)
Changed paths: 13
Log Message:
cc: Remove all usage of GetArea() from production code in cc

Consolidate the calls to turn gfx::Size into a number of bytes onto
the cc::SharedBitmap class. The class offers the following methods:
1. Get a size_t bytes and bool saying if you overflowed or not.
2. Get a size_t bytes and crash if you overflow.
3. Get a size_t bytes and don't check for overflow.
4. Tell me if the gfx::Size would overflow to create the size_t bytes.

These were the use cases I found in the existing code, plus the
addition of case 2. A few places that were finding the size_t bytes
without looking for overflow (case 3), from a previously-unchecked
gfx::Size, were changed to crash on overflow instead (case 2).

R=jbauman@chromium.org, piman@chromium.org
BUG=348332

Review URL: https://codereview.chromium.org/221523003

Changed paths

Path Details
Directorytrunk/src/cc/layers/texture_layer_impl.cc modified , text changed
Directorytrunk/src/cc/output/software_frame_data.cc modified , text changed
Directorytrunk/src/cc/output/software_frame_data.h modified , text changed
Directorytrunk/src/cc/resources/resource_provider.cc modified , text changed
Directorytrunk/src/cc/resources/shared_bitmap.cc modified , text changed
Directorytrunk/src/cc/resources/shared_bitmap.h modified , text changed
Directorytrunk/src/cc/resources/texture_mailbox.cc modified , text changed
Directorytrunk/src/cc/resources/texture_mailbox.h modified , text changed
Directorytrunk/src/content/browser/renderer_host/software_frame_manager.cc modified , text changed
Directorytrunk/src/content/child/child_shared_bitmap_manager.cc modified , text changed , props changed
Directorytrunk/src/content/common/cc_messages.cc modified , text changed
Directorytrunk/src/content/common/host_shared_bitmap_manager.cc modified , text changed , props changed
Directorytrunk/src/content/common/host_shared_bitmap_manager_unittest.cc modified , text changed , props changed

Properties

Name Value
commit-bot commit-bot@chromium.org

Powered by ViewVC 1.1.26 ViewVC Help